New update/remove APIs for SparseAddressOrderedFixedSizeDataPool #7614
+156
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new APIs isValidDataPtr() verifyAndUnmapSparseDataPtrFromHeapProxyObjectPtr() verifyAndUpdateSparseDataEntryAfterObjectHasMoved() before update/remove entry from SparseAddressOrderedFixedSizeDataPool, check if dataPtr is consistent with related size and associated proxy object. keep unadjusted original array size instead of aligned size in MM_SparseDataTableEntry. findFreeListEntry/returnFreeListEntry/decommitMemory/ decommitMemory need to use adjustedSize. mapSparseDataPtrToHeapProxyObjectPtr and unmapSparseDataPtrFromHeapProxyObjectPtr use unadjusted original array size. Signed-off-by: lhu <[email protected]>
|
@amicic @dmitripivkine please review the changes, Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new APIs
isValidDataPtr()
verifyAndUnmapSparseDataPtrFromHeapProxyObjectPtr() verifyAndUpdateSparseDataEntryAfterObjectHasMoved() before update/remove entry from
SparseAddressOrderedFixedSizeDataPool, check if dataPtr is consistent with related size and associated proxy object.
keep unadjusted original array size instead of aligned size in MM_SparseDataTableEntry.
findFreeListEntry/returnFreeListEntry/decommitMemory/ decommitMemory need to use adjustedSize.
mapSparseDataPtrToHeapProxyObjectPtr
and unmapSparseDataPtrFromHeapProxyObjectPtr use unadjusted original array size.