-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x86: Enable dual TLH by default #7234
Conversation
Signed-off-by: Bradley Wood <[email protected]>
I would appreciate a review from @0xdaryl on this to make sure we have considered what we need to, before making this change |
I would also advise a small unit test in this case where you have an allocation of each kind, one that needs zeroing and one that does not, and check the generated code sequences to make sure that it is all as expected (i.e. we use the two TLHs in the expected way). |
Also FYI, @mpirvu for any memory footprint impacts |
I am only approving the fact that the enablement looks okay. I'll wait for Daryl's review and run tests. |
jenkins build all |
MacOS failure is #7181 Windows Failed due to:
|
Dual TLH is disabled by default on AArch64 now. PR #7243. |
Is batch clearing enabled by default on AArch64 ? If not, is it being considered to be enabled by default ? |
@vijaysun-omr TLH batch clearing is enabled by default on AArch64. See my comment in eclipse-openj9/openj9#18870 (comment). |
No description provided.