Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AArch64: Fix build break by duplicated evaluators #6040

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

knn-k
Copy link
Contributor

@knn-k knn-k commented Jun 1, 2021

Duplicated definitions of some evaluators cause build breaks.
This commit fixes them.

Signed-off-by: KONNO Kazuhiro [email protected]

Duplicated definitions of some evaluators cause build breaks.
This commit fixes them.

Signed-off-by: KONNO Kazuhiro <[email protected]>
@knn-k
Copy link
Contributor Author

knn-k commented Jun 1, 2021

Jenkins build aarch64

@knn-k
Copy link
Contributor Author

knn-k commented Jun 2, 2021

fcmpl/fcmpg evaluators are implemented in #6026, and dmax/dmin evaluators are implemented in #6027.
Other evaluators have been defined in ControlFlowEvaluator.cpp, and #5720 added redundant definitions to OMRTreeEvaluator.cpp.

@knn-k knn-k changed the title AArch64: Fix build break AArch64: Fix build break by duplicated evaluators Jun 2, 2021
@0xdaryl 0xdaryl self-assigned this Jun 2, 2021
@0xdaryl 0xdaryl merged commit 76bff20 into eclipse-omr:master Jun 2, 2021
@knn-k knn-k deleted the aarch64-fix-eval-dup branch June 2, 2021 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants