Fix b2iEvaluator in power for bRegLoad #5748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnalam-p
force-pushed
the
cons_charset_failure
branch
from
abf3643 to
993979e
Compare
|
@gita-omr kindly review the changes. Thanks in advance. |
|
I think the PR description needs to be changed. JProfiler just exposed the problem in the Power b2iEvaluator. That problem can be exposed in many other situations. |
|
I think it's better to describe the issue in the evaluator itself. It assumed that bRegload has byte sign extended and therefore skipped the extension. However the value of bRegload node is not necessarily sign extended. |
The b2iEvaluator currently does not generate sign extension for bRegLoad. While it will work for sign extended bRegLoad, it may yield wrong result if the byte was not sign extended. This commit cover such cases, by making sure bRegLoad is always sign extended. Fixes: eclipse-openj9/openj9#11192 Signed-off-by: Mohammad Nazmul Alam <[email protected]>
mnalam-p
force-pushed
the
cons_charset_failure
branch
from
993979e to
5ae1d2b
Compare
gita-omr
approved these changes
Jan 15, 2021
|
@aviansie-ben could you please review/merge ? |
|
@genie-omr build plinux,aix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The b2iEvaluator currently does not generate sign extension for
bRegLoad. While it will work for sign extended bRegLoad, it may
yield wrong result if the byte was not sign extended. This commit
cover such cases, by making sure bRegLoad is always sign extended.
Fixes: eclipse-openj9/openj9#11192
Signed-off-by: Mohammad Nazmul Alam [email protected]