Enlarge SwitchAnalyzer successor counter #4450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you fix the spelling of "switch" in the commit title and body please? |
The switch analyzer currently uses an int8_t counter to count the number of time a given block is a successor of the swtich/table. This can easily overflow and result in undefined behaviour by the C++ code. This change enlarges the compiler to int32_t to prevent this kind of overflow and improves the assert to ensure a sesnible number is being generated. Signed-off-by: Andrew Craik <[email protected]>
andrewcraik
force-pushed
the
fixSwitchOverflow
branch
from
13971b3
to
d62088e
Compare
andrewcraik
changed the title
|
Commit amended with spelling fix and fixed PR message as well. |
|
@genie-omr build all |
|
I am fine with the proposed fix. |
vijaysun-omr
approved these changes
Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The switch analyzer currently uses an int8_t counter to count the number
of time a given block is a successor of the swtich/table. This can easily
overflow and result in undefined behaviour by the C++ code. This change
enlarges the compiler to int32_t to prevent this kind of overflow and
improves the assert to ensure a sesnible number is being generated.
Signed-off-by: Andrew Craik [email protected]