Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extending the current wrtbar opcode to xwrtbar/xwrtbari #2948

Closed
cathyzhyi opened this issue Sep 10, 2018 · 1 comment
Closed

Extending the current wrtbar opcode to xwrtbar/xwrtbari #2948

cathyzhyi opened this issue Sep 10, 2018 · 1 comment
Labels
architecture review pending comp:compiler

Comments

@cathyzhyi
Copy link
Contributor

cathyzhyi commented Sep 10, 2018 •
edited
Loading

Write barrier opcodes are needed to represent a store as well as the extra side effects like notify the VM of the write for debugging purpose. There are current already wrtbar and wrtbari for address type direct and indirect stores and we are extending the opcodes and the syntax to other types.

Indirect write barrier looks like the following:

xwrtbari <#xxx A.instanceB>
  baseObject
  valueToStore
  extra Info needed by the extra side affect

Direct write barrier looks like the following:

xwrtbar <#xxx A.staticB>
  valueToStore
  extra Info needed by the extra side affect

see PR #3027 for actual implementation
@0xdaryl 0xdaryl mentioned this issue Sep 11, 2018
Closed
@cathyzhyi cathyzhyi mentioned this issue Oct 4, 2018
Closed
5 tasks
cathyzhyi pushed a commit to cathyzhyi/omr that referenced this issue Oct 4, 2018
Add wrtbar/wrtbari opcodes
6fd2f90 
The xwrtbar/xwrtbari opcodes are added to represent both the store
as well as its side effects like checking object address against
tenure address range for GC, notifying the VM of the store or
other similar activities.

This PR adds the most basic supports for write barrier opcodes. The
exist wrtbar/wrtbari are change to awrtbar/awrtbari for consistency.
By default write barriers use store handlers and evaluators.

issue: eclipse-omr#2948

Signed-off-by: Yi Zhang <[email protected]>
@cathyzhyi cathyzhyi mentioned this issue Oct 4, 2018
Merged
cathyzhyi pushed a commit to cathyzhyi/omr that referenced this issue Oct 4, 2018
Add wrtbar/wrtbari opcodes
9d0e4d6 
The xwrtbar/xwrtbari opcodes are added to represent both the store
as well as its side effects like checking object address against
tenure address range for GC, notifying the VM of the store or
other similar activities.

This PR adds the most basic supports for write barrier opcodes. The
exist wrtbar/wrtbari are change to awrtbar/awrtbari for consistency.
By default write barriers use store handlers and evaluators.

issue: eclipse-omr#2948

Signed-off-by: Yi Zhang <[email protected]>
cathyzhyi pushed a commit to cathyzhyi/omr that referenced this issue Oct 4, 2018
Add wrtbar/wrtbari opcodes
5ebab5b 
The xwrtbar/xwrtbari opcodes are added to represent both the store
as well as its side effects like checking object address against
tenure address range for GC, notifying the VM of the store or
other similar activities.

This PR adds the most basic supports for write barrier opcodes. The
exist wrtbar/wrtbari are change to awrtbar/awrtbari for consistency.
By default write barriers use store handlers and evaluators.

issue: eclipse-omr#2948

Signed-off-by: Yi Zhang <[email protected]>
cathyzhyi pushed a commit to cathyzhyi/omr that referenced this issue Oct 4, 2018
Add wrtbar/wrtbari opcodes
c5b8866 
The xwrtbar/xwrtbari opcodes are added to represent both the store
as well as its side effects like checking object address against
tenure address range for GC, notifying the VM of the store or
other similar activities.

This PR adds the most basic supports for write barrier opcodes. The
exist wrtbar/wrtbari are change to awrtbar/awrtbari for consistency.
By default write barriers use store handlers and evaluators.

issue: eclipse-omr#2948

Signed-off-by: Yi Zhang <[email protected]>
cathyzhyi pushed a commit to cathyzhyi/omr that referenced this issue Oct 4, 2018
Add wrtbar/wrtbari opcodes
65c5ceb 
The xwrtbar/xwrtbari opcodes are added to represent both the store
as well as its side effects like checking object address against
tenure address range for GC, notifying the VM of the store or
other similar activities.

This PR adds the most basic supports for write barrier opcodes. The
exist wrtbar/wrtbari are change to awrtbar/awrtbari for consistency.
By default write barriers use store handlers and evaluators.

issue: eclipse-omr#2948

Signed-off-by: Yi Zhang <[email protected]>
cathyzhyi pushed a commit to cathyzhyi/omr that referenced this issue Oct 5, 2018
Add wrtbar/wrtbari opcodes
189c5b2 
The xwrtbar/xwrtbari opcodes are added to represent both the store
as well as its side effects like checking object address against
tenure address range for GC, notifying the VM of the store or
other similar activities.

This PR adds the most basic supports for write barrier opcodes. The
exist wrtbar/wrtbari are change to awrtbar/awrtbari for consistency.
By default write barriers use store handlers and evaluators.

issue: eclipse-omr#2948

Signed-off-by: Yi Zhang <[email protected]>
cathyzhyi pushed a commit to cathyzhyi/omr that referenced this issue Oct 9, 2018
Add wrtbar/wrtbari opcodes
2a9c467 
The xwrtbar/xwrtbari opcodes are added to represent both the store
as well as its side effects like checking object address against
tenure address range for GC, notifying the VM of the store or
other similar activities.

This PR adds the most basic supports for write barrier opcodes. The
exist wrtbar/wrtbari are change to awrtbar/awrtbari for consistency.
By default write barriers use store handlers and evaluators.

issue: eclipse-omr#2948

Signed-off-by: Yi Zhang <[email protected]>
cathyzhyi pushed a commit to cathyzhyi/omr that referenced this issue Oct 24, 2018
Add wrtbar/wrtbari opcodes
2457f09 
The xwrtbar/xwrtbari opcodes are added to represent both the store
as well as its side effects like checking object address against
tenure address range for GC, notifying the VM of the store or
other similar activities.

This PR adds the most basic supports for write barrier opcodes. The
exist wrtbar/wrtbari are change to awrtbar/awrtbari for consistency.
By default write barriers use store handlers and evaluators.

issue: eclipse-omr#2948

Signed-off-by: Yi Zhang <[email protected]>
@cathyzhyi cathyzhyi mentioned this issue Dec 12, 2018
Merged
@cathyzhyi
Copy link
Contributor Author

related work has been completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
architecture review pending comp:compiler
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cathyzhyi @0xdaryl