-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docker): add arm64 images #90
Conversation
ebf6f48
to
8d246d8
Compare
- Add a workaround for slow performance of amd64-arm64-QEMU yarn install by caching arm images
8d246d8
to
78b8d00
Compare
f767523
to
5e3c449
Compare
DRAFT again: Github does not allow secrets to be used in PR from forks and of course inside forks. 😢 |
289e1ac
to
82ea622
Compare
KEYCLOAK_REALM: mnestix-realm | ||
|
||
keycloak: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For an open source project it would be good to not rely on external secured services so there is now a docker internal.
Allowing both would be too complex and the internal one isn't that slow as the slowest piece in startup is still the aas-environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Basyx Realm didn’t work for me, so I created a simpler Mnestix Realm instead. With this setup, the tests work, and it makes integration with an existing Keycloak instance easier. Additionally, it helps document what Mnestix requires in Keycloak. If this redundancy is unnecessary, I can remove the file again.
Not working
I think one problem is that there is an "role" property and it should be "roles". At least it works with "roles" for me. ![image](https://github.com/user-attachments/assets/df5d07de-647a-4f25-8975-a4009928c148)82ea622
to
671f8c6
Compare
Description
arm64 images are currently missing in dockerhub mnestix. arm is often cheaper when using at cloud providers.
Unfortunately
yarn install
is taking ages with qemu/arm64 so there I had to add a caching step for building the arm image. If you don't want this complexity I could remove this but I thought faster pipelines even for deployment are always good.Successful run
Successful build
Type of change
I could not thoroughly test this because I didn't want to hassle with dockerhub but merging this to dev and looking if the image is present then should be enough.
If not it would be a bit of effort.
Checklist: