Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker): add arm64 images #90

Merged
merged 5 commits into from
Feb 13, 2025

Conversation

sirchnik-xitaso
Copy link
Contributor

@sirchnik-xitaso sirchnik-xitaso commented Feb 3, 2025

Description

arm64 images are currently missing in dockerhub mnestix. arm is often cheaper when using at cloud providers.

Unfortunately yarn install is taking ages with qemu/arm64 so there I had to add a caching step for building the arm image. If you don't want this complexity I could remove this but I thought faster pipelines even for deployment are always good.
Successful run
Successful build

Type of change

  • Minor change (non-breaking change, e.g. documentation adaption)
    I could not thoroughly test this because I didn't want to hassle with dockerhub but merging this to dev and looking if the image is present then should be enough.
    If not it would be a bit of effort.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix or my feature works
  • New and existing tests pass locally with my changes
  • My changes contain no console logs

  - Add a workaround for slow performance of amd64-arm64-QEMU yarn install
    by caching arm images
@sirchnik-xitaso sirchnik-xitaso force-pushed the arm-images branch 3 times, most recently from f767523 to 5e3c449 Compare February 4, 2025 13:46
@sirchnik-xitaso
Copy link
Contributor Author

sirchnik-xitaso commented Feb 4, 2025

DRAFT again: Github does not allow secrets to be used in PR from forks and of course inside forks. 😢

@sirchnik-xitaso sirchnik-xitaso marked this pull request as draft February 4, 2025 14:14
@sirchnik-xitaso sirchnik-xitaso force-pushed the arm-images branch 2 times, most recently from 289e1ac to 82ea622 Compare February 5, 2025 12:57
KEYCLOAK_REALM: mnestix-realm

keycloak:
Copy link
Contributor Author

@sirchnik-xitaso sirchnik-xitaso Feb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For an open source project it would be good to not rely on external secured services so there is now a docker internal.

Allowing both would be too complex and the internal one isn't that slow as the slowest piece in startup is still the aas-environment.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point :)

Copy link
Contributor Author

@sirchnik-xitaso sirchnik-xitaso Feb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Basyx Realm didn’t work for me, so I created a simpler Mnestix Realm instead. With this setup, the tests work, and it makes integration with an existing Keycloak instance easier. Additionally, it helps document what Mnestix requires in Keycloak. If this redundancy is unnecessary, I can remove the file again.

Not working I think one problem is that there is an "role" property and it should be "roles". At least it works with "roles" for me. ![image](https://github.com/user-attachments/assets/df5d07de-647a-4f25-8975-a4009928c148)

package.json Outdated Show resolved Hide resolved
@sirchnik-xitaso sirchnik-xitaso marked this pull request as ready for review February 5, 2025 13:29
pawel-baran-se
pawel-baran-se previously approved these changes Feb 6, 2025
@hofermo hofermo merged commit a0b47f8 into eclipse-mnestix:dev Feb 13, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants