Test JPMS fails

[laeubi]

No description provided.

[github-actions]

Test Results

  214 files  ±0    214 suites  ±0   22m 50s ⏱️ + 1m 51s
  664 tests ±0    653 ✅  - 1  10 💤 ±0  1 ❌ +1 
1 328 runs  ±0  1 305 ✅  - 1  22 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 18c3042. ± Comparison against base commit 6880fa1.

[laeubi]

I also checked this test in the local IDE and it works there correctly.

[treilhes]

Hello @laeubi,

I was also looking into it to solve the failing test for my PR #1672 and i did reproduce the issue and found the following:

In JpmsConfigurationTest
When updating the pom content (line 103)

pomFileWS.setContents(new ByteArrayInputStream(argsSet1Content.getBytes()), true, false, null);

A IResourceChangeEvent is triggered but MavenUpdateConfigurationChangeListener never receive the event so the project JreContainer isn't updated when we want to get properties from jreAttributes.

Why ? Because MavenUpdateConfigurationChangeListener isn't registered as a listener into the NotificationManager

The MavenUpdateConfigurationChangeListener is supposed to be regsitered in M2EUIPluginActivator.start() but in this case the start method is never called.

I was able to solve the issue by removing some lines from org.eclipse.m2e.core.ui\META-INF\MANIFEST.MF

By removing the latest 6 lines from the manifest:

Service-Component: OSGI-INF/org.eclipse.m2e.core.ui.internal.archetype.ArchetypeGenerator.xml,
 OSGI-INF/org.eclipse.m2e.core.ui.internal.archetype.ArchetypePlugin.xml
Bundle-ActivationPolicy: lazy
Service-Component: OSGI-INF/org.eclipse.m2e.core.ui.internal.archetype.ArchetypeGenerator.xml,
 OSGI-INF/org.eclipse.m2e.core.ui.internal.archetype.ArchetypePlugin.xml
Bundle-ActivationPolicy: lazy

I don't have any knowledge about osgi but it seems those directives are duplicates but it is just a guess

[laeubi]

@treilhes interesting observation, do you like to open a PR that removes the duplicates, this does not looks correct it seems these are cam in by c3fa2ed as an accident (maybe merge /rebase problem)

[treilhes]

#1679 created, waiting for the build judgement

[treilhes]

#1679 Seems good