-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve conflict handling of lifecycle mappings #549
Comments
@kwin thanks for your suggestion, do you plan to give it a try and provide a PR for this? |
@laeubi Not in the short-term I fear. |
@mickaelistria @HannesWell could you help here? I think this can become important once we release 1.20 as there might also be collisions with the old takari mapping for tycho. |
I don't plan to work on this issue. If the solution is to remove the old takari mapping of Tycho, then we can imagine have the m2e-PDE feature adding a negative requirement towards the takari stuff so we at least ensure both cannot be installed together. |
Okay I'll try to take a look at this I think this is crucial for this release as we will otherwise get complains from users and the current behavior is simply not helpful. |
Thank you Christoph! I agree that this is important but I actually didn't have the plan to work on this, so I'm thankful that you take over. If you need somebody to review, please let me know. |
- record what is causing the conflict - add the exception to the maven problem - show problem markers at the correct location in the pom Signed-off-by: Christoph Läubrich <[email protected]>
- record what is causing the conflict - add the exception to the maven problem - show problem markers at the correct location in the pom Signed-off-by: Christoph Läubrich <[email protected]>
- record what is causing the conflict - add the exception to the maven problem - show problem markers at the correct location in the pom Signed-off-by: Christoph Läubrich <[email protected]>
- record what is causing the conflict - add the exception to the maven problem - show problem markers at the correct location in the pom - save conflicting configurator ids for executions Signed-off-by: Christoph Läubrich <[email protected]>
- record what is causing the conflict - add the exception to the maven problem - show problem markers at the correct location in the pom - save conflicting bundles at the marker Signed-off-by: Christoph Läubrich <[email protected]>
- record what is causing the conflict - add the exception to the maven problem - show problem markers at the correct location in the pom - save conflicting bundles at the marker Signed-off-by: Christoph Läubrich <[email protected]>
- record what is causing the conflict - add the exception to the maven problem - show problem markers at the correct location in the pom - save conflicting bundles at the marker Signed-off-by: Christoph Läubrich <[email protected]>
Signed-off-by: Christoph Läubrich <[email protected]>
This then adds for example the following to the workspace metadata:
|
In case two extensions with overlapping lifecycle mapping (like PDE Connector and Sling IDE Tooling in
m2e-core/org.eclipse.m2e.pde.connector/lifecycle-mapping-metadata.xml
Line 39 in 50ed92a
are emitted for projects leveraging plugins which are affected by the conflicting lifecycle mapping and incremental support for that plugin & goal (in this example
bnd-process
) is completely disabled.Instead in case of conflicts it should be possible for a user to decide on a per-project level which lifecycle mapping should be used.
The text was updated successfully, but these errors were encountered: