Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional "runtime" scoped dependencies support? #543

Closed
laeubi opened this issue Feb 1, 2022 Discussed in #461 · 5 comments
Closed

Additional "runtime" scoped dependencies support? #543

laeubi opened this issue Feb 1, 2022 Discussed in #461 · 5 comments
Assignees
Milestone

Comments

@laeubi
Copy link
Member

laeubi commented Feb 1, 2022

Discussed in #461

Originally posted by laeubi December 18, 2021
Now that we correctly filter dependencies scopes it shows that it might cause confusion for runtime scoped dependencies.

The runtime scope is a bit special as maven defines it as:

runtime
This scope indicates that the dependency is not required for compilation, but is for execution. Maven includes a dependency with this scope in the runtime and test classpaths, but not the compile classpath.

That mean that if we want it currently one has to select test scope.

I see the following options:

  1. We allow to select runtime scope and handle it as something between compile and test (include everything compile would include and include runtime dependencies but not test scoped ones.
  2. We add a boolean attribute includeRuntime that additionally include runtime scoped dependencies
  3. We do nothing an require people to explicitly include those if the only want compile scope

@akurtakov @mickaelistria @HannesWell any preferences?

@akurtakov @mickaelistria @HannesWell I think it would be good t have this in before the next release see also

@laeubi laeubi added this to the 1.20.0 milestone Feb 1, 2022
@mickaelistria
Copy link
Contributor

Solution 1 seems to be the most correct from Maven and PDE POV. The "runtime" scope should also be the default scope in the UI as per expectation of target platform definition.

@laeubi
Copy link
Member Author

laeubi commented Feb 1, 2022

I'll try to fix this this week, as I think we should include thin the the 1.20 release.

@laeubi laeubi self-assigned this Feb 4, 2022
laeubi added a commit to laeubi/m2e-core that referenced this issue Feb 4, 2022
@laeubi
Copy link
Member Author

laeubi commented Feb 4, 2022

Target used for testing Issue_543.target.zip

@laeubi laeubi closed this as completed in b6d16d2 Feb 4, 2022
@laeubi
Copy link
Member Author

laeubi commented Feb 4, 2022

@vogella @akurtakov @HannesWell this should shortly be available in the snapshot please test this if it works for all your cases (but keep in mind that tycho do not support this at the moment!) if no issues arise I'll adjust tycho support accordingly.

@laeubi
Copy link
Member Author

laeubi commented Feb 5, 2022

Also fixed in tycho now: eclipse-tycho/tycho#447

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants