update to guava 32 and orbit 2023-09 #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Dietrich <[email protected]>
cdietrich
commented
Aug 3, 2023
cdietrich
commented
Aug 3, 2023
|
is there no jenkins anymore? |
Not for PRs, but for branches. It looks like it is hung though - https://ci.eclipse.org/lsp4j/job/lsp4j-multi-build/job/cd_guavaBmp/1/console |
jonahgraham
reviewed
Aug 3, 2023
It looks like a transient Jenkins issue - job 3 worked fine and is reporting back to the here successfully. |
jonahgraham
approved these changes
Aug 3, 2023
|
thx for fixing typo |
jonahgraham
reviewed
Aug 4, 2023
|
Once this builds successfully I will merge it assuming no objections. |
|
The macOS Jakarta websocket tests seem unstable. Not sure if this is a new instability, but they have failed ~25% of the time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update to guava 32 and orbit 2023-09