Wrap primitive and array parameter into an array as in JSON-RPC 2.0 #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahgraham
approved these changes
Apr 11, 2023
jonahgraham
reviewed
Jun 1, 2023
| @@ -42,6 +43,7 @@ | |||
| import com.google.gson.JsonSyntaxException; | |||
| import com.google.gson.TypeAdapter; | |||
| import com.google.gson.TypeAdapterFactory; | |||
| import com.google.gson.internal.Primitives; | |||
There was a problem hiding this comment.
@jonahgraham
Sure, will do. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The counter part off my previous PR handling the unwrapping of primitiv and array parameter types as described in JSON-RPC 2.0.
Added more tests with different parameter types that hopefully makes clear what in wrapped/unwrapped.
See also: #553