-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Notebook support #642
Add Notebook support #642
Conversation
Signed-off-by: Matthew Brown <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have checked it against the spec. Great work, as always! Minor suggestions attached.
org.eclipse.lsp4j/src/main/java/org/eclipse/lsp4j/Protocol.xtend
Outdated
Show resolved
Hide resolved
org.eclipse.lsp4j/src/main/java/org/eclipse/lsp4j/Protocol.xtend
Outdated
Show resolved
Hide resolved
org.eclipse.lsp4j/src/main/java/org/eclipse/lsp4j/Protocol.xtend
Outdated
Show resolved
Hide resolved
Signed-off-by: Matthew Brown <[email protected]>
6168c24
to
dbd84ed
Compare
Signed-off-by: Matthew Brown <[email protected]>
dbd84ed
to
68ced59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
So I tried using the PR and I noticed that |
@Cyrik Sorry. This is my first time adding a new service, so I missed some things. |
Signed-off-by: Matthew Brown <[email protected]>
da79045
to
e3fa7b0
Compare
No problem at all, thank you for the fast update! I didn't notice the missing bit either until I wanted to pass in my service 😄 |
I just tried to use the new version but there seems to be no snapshot of it. Can I somehow trigger the build myself? |
It looks like this build includes the latest changes, does not it? |
ah yes, thank you. I didn't find that link and was trying to use the nightly or build it myself 😅 |
I've tested all the notebookDocument/* calls and they work for me! Capabilities also produce the correct results. So I'd be happy to have this merged and base our next LSP version on it. |
Fixes #640