Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAP has integer in the spec that probably should be mapped to Integer instead of Long #392

Closed
jonahgraham opened this issue Jan 3, 2020 · 2 comments
Closed

DAP has integer in the spec that probably should be mapped to Integer instead of Long #392

jonahgraham opened this issue Jan 3, 2020 · 2 comments
Assignees
@jonahgraham
Milestone
v0.9.0

Comments

@jonahgraham
Copy link
Contributor

@jonahgraham What was the reason for keeping some of the fields as Long? All of the numeric properties in the DAP schema appear to be integer now. Unfortunately, it doesn't appear that the auto-generated spec file accounts for this since it just uses TypeScript representations. I've opened an issue with DAP for this.

Originally posted by @KamasamaK in #376 (comment)
@jonahgraham jonahgraham self-assigned this Jan 3, 2020
@jonahgraham jonahgraham added this to the v0.9.0 milestone Jan 3, 2020
@jonahgraham
Copy link
Contributor Author

@KamasamaK I have put this to be handled before 0.9.0 ships so that we are only changing this API once.

@KamasamaK KamasamaK mentioned this issue Jan 18, 2020
Closed
jonahgraham added a commit that referenced this issue Jan 27, 2020
@jonahgraham
Bug #392: Map appropriate debug fields to Integer instead of Long
978d50e 
The initial implementation of lsp4j.debug used Long to map JSON's
integer values as the debug protocol spec did not provide range
information.

See also microsoft/debug-adapter-protocol#90
jonahgraham added a commit that referenced this issue Jan 27, 2020
@jonahgraham
Bug #392: Map appropriate debug fields to Integer instead of Long
a0c979f 
The initial implementation of lsp4j.debug used Long to map JSON's
integer values as the debug protocol spec did not provide range
information.

See also microsoft/debug-adapter-protocol#90
jonahgraham added a commit that referenced this issue Jan 30, 2020
@jonahgraham
Bug #392: Map appropriate debug fields to Integer instead of Long
85c9670 
The initial implementation of lsp4j.debug used Long to map JSON's
integer values as the debug protocol spec did not provide range
information.

See also microsoft/debug-adapter-protocol#90
@jonahgraham
Copy link
Contributor Author

Fixed merged as part of PR #401

@jonahgraham jonahgraham mentioned this issue Feb 27, 2020
Closed
vladdu pushed a commit to vladdu/lsp4j that referenced this issue Jan 26, 2021
@jonahgraham @vladdu
Bug eclipse-lsp4j#392: Map appropriate debug fields to Integer instea…
242f381 
…d of Long

The initial implementation of lsp4j.debug used Long to map JSON's
integer values as the debug protocol spec did not provide range
information.

See also microsoft/debug-adapter-protocol#90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonahgraham jonahgraham

Labels
None yet
Projects
None yet
Milestone
v0.9.0
Development

No branches or pull requests
1 participant
@jonahgraham