Fix selective formatting (issue #1127)

[travkin79]

This PR fixes selective formatting.

[travkin79]

I think, my fix is ready, but I'd like to add an automated test for that case, too.

[rubenporras]

Thanks for the fix. It looks good to me but I will wait for the test case before merging.

[travkin79]

I think, now, the PR is ready to be merged. But please take a look at the following line. Is that the right thing to be returned in this case?

https://github.com/travkin79/lsp4e/blob/15350a9bff093771bc306cf06ffea2f25d9106c7/org.eclipse.lsp4e/src/org/eclipse/lsp4e/operations/format/LSPFormatter.java#L66

[travkin79]

Hi @rubenporras,
Since this bugfix is important and urgent for my team, when do you plan to make the next LSP4E release?

[rubenporras]

I think, now, the PR is ready to be merged. But please take a look at the following line. Is that the right thing to be returned in this case?

https://github.com/travkin79/lsp4e/blob/15350a9bff093771bc306cf06ffea2f25d9106c7/org.eclipse.lsp4e/src/org/eclipse/lsp4e/operations/format/LSPFormatter.java#L66

I am also not sure and you implementation seems sensible.

In any case, I think that if the client pays attention to the capabilities of the client, we should never reach this code.

[rubenporras]

Hi @rubenporras, Since this bugfix is important and urgent for my team, when do you plan to make the next LSP4E release?

In that case, I will prepare a new release today or tomorrow.

[rubenporras]

Hi @travkin79 ,

you have a new release ;)

Cheers.

[travkin79]

you have a new release ;)

Hi @rubenporras,
That's awesome! Thank you very much. :-)

One more thing: I think, we can close the issue #1127 now.