NPE on hover on malformed document

[angelozerr]

NPE on hover on malformed document

Fixes #984

Signed-off-by: azerr [email protected]

[datho7561]

I think this is the correct solution, but the test doesn't actually reproduce the issue from what I can tell.

[datho7561]

This test passes even if the null check isn't present.

[angelozerr]

It's because exception is cached, so we don't see the problem. But this PR clean the usecase and doesn't throw the NPE exception.

[datho7561]

Okay. I don't see the point of including this test case if it doesn't reproduce the issue.

[angelozerr]

I would like to keep it because without this fix we see a error stack trace when test is executed.

[datho7561]

Okay. I can see why this would be helpful, but its very easy to miss this exception in the output. I think it would be better to write a unit test on ContentModelHoverParticipant.onText() so that the build will fail if this behaviour is changed.

[datho7561]

I think a test like this would be more helpful:

@Test
public void hoverWithNullParentNode() throws Exception {
	ContentModelHoverParticipant hoverParticipant = new ContentModelHoverParticipant();
	IHoverRequest hoverRequest = new IHoverRequest() {
		// default auto-suggested implementation for other methods
		@Override
		public DOMNode getNode() {
			return new DOMText(0, 0);
		}
			
	};
	assertNull(hoverParticipant.onText(hoverRequest));
}

[datho7561]

See #1001

[angelozerr]

Replace with #1001