Fix error range for cvc-complex-type-2.3 #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, I don't think I quite understand the second part. Is this so that it highlights between the pipes in this case? <elementsOnly>
|text content
<child />
more text content|
</elementsOnly> |
datho7561
force-pushed
the
885-cvc-complex-type-2-3
branch
from
3c0d174 to
e7a530c
Compare
|
^fixed the first case |
I think you will not have cvc-complex-type-2.3 error in this case. |
datho7561
force-pushed
the
885-cvc-complex-type-2-3
branch
from
e7a530c to
3b2dd72
Compare
Now handles text nodes that are only take up one line, as well as <![CDATA[]]>. Closes eclipse-lemminx#885 Signed-off-by: David Thompson <[email protected]>
datho7561
force-pushed
the
885-cvc-complex-type-2-3
branch
from
3b2dd72 to
af94419
Compare
|
Thanks for the help, Angelo! I avoided using |
|
Works like a charm. Great job @datho7561 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now handles text nodes that are only take up one line, as well as
<![CDATA[]]>.Closes #885
Signed-off-by: David Thompson [email protected]