XML completion based on DTD with XML catalog and PUBLIC declaration doesn't work #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelozerr
force-pushed
the
fix-dtd-catalog-completion
branch
from
e80bdb8 to
0e01ecb
Compare
doesn't work Fixes eclipse-lemminx#849 Signed-off-by: azerr <[email protected]>
|
@datho7561 could you review this PR please. The usecase is the same than #848 but it fixes XML completion based on DTD. |
|
Okay |
datho7561
approved these changes
Aug 20, 2020
|
Thanks @datho7561 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XML completion based on DTD with XML catalog and PUBLIC declaration
doesn't work
Fixes #849
Signed-off-by: azerr [email protected]