Added document links for xsi:schemaLocation #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelozerr
reviewed
Jun 10, 2020
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/dom/SchemaLocationHint.java
Outdated
Show resolved
Hide resolved
angelozerr
reviewed
Jun 10, 2020
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/dom/SchemaLocationHint.java
Outdated
Show resolved
Hide resolved
angelozerr
reviewed
Jun 10, 2020
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/dom/SchemaLocationHint.java
Outdated
Show resolved
Hide resolved
angelozerr
reviewed
Jun 10, 2020
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/dom/SchemaLocationHint.java
Outdated
Show resolved
Hide resolved
angelozerr
reviewed
Jun 10, 2020
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/dom/SchemaLocationHint.java
Show resolved
Hide resolved
angelozerr
reviewed
Jun 10, 2020
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/dom/SchemaLocationHint.java
Show resolved
Hide resolved
datho7561
force-pushed
the
doc-link-xsi-schema-location
branch
from
a7db73e to
040331c
Compare
angelozerr
reviewed
Jun 11, 2020
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/dom/SchemaLocation.java
Outdated
Show resolved
Hide resolved
angelozerr
reviewed
Jun 11, 2020
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/dom/SchemaLocation.java
Show resolved
Hide resolved
angelozerr
reviewed
Jun 11, 2020
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/dom/SchemaLocation.java
Outdated
Show resolved
Hide resolved
datho7561
force-pushed
the
doc-link-xsi-schema-location
branch
2 times, most recently
from
6e25979 to
decfbfd
Compare
datho7561
force-pushed
the
doc-link-xsi-schema-location
branch
from
decfbfd to
77d1599
Compare
datho7561
commented
Jun 11, 2020
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/dom/SchemaLocation.java
Outdated
Show resolved
Hide resolved
datho7561
force-pushed
the
doc-link-xsi-schema-location
branch
from
77d1599 to
79d13a3
Compare
angelozerr
reviewed
Jun 11, 2020
...inx/src/test/java/org/eclipse/lemminx/extensions/contentmodel/XMLSchemaDocumentLinkTest.java
Show resolved
Hide resolved
datho7561
force-pushed
the
doc-link-xsi-schema-location
branch
from
79d13a3 to
41aa969
Compare
xorye
reviewed
Jun 11, 2020
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/dom/SchemaLocation.java
Show resolved
Hide resolved
xorye
reviewed
Jun 11, 2020
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/dom/SchemaLocation.java
Outdated
Show resolved
Hide resolved
xorye
reviewed
Jun 11, 2020
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/dom/SchemaLocation.java
Outdated
Show resolved
Hide resolved
xorye
reviewed
Jun 11, 2020
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/dom/SchemaLocation.java
Outdated
Show resolved
Hide resolved
xorye
reviewed
Jun 11, 2020
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/dom/SchemaLocationHint.java
Outdated
Show resolved
Hide resolved
xorye
reviewed
Jun 11, 2020
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/dom/SchemaLocationHint.java
Outdated
Show resolved
Hide resolved
xorye
reviewed
Jun 11, 2020
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/dom/SchemaLocationHint.java
Outdated
Show resolved
Hide resolved
datho7561
force-pushed
the
doc-link-xsi-schema-location
branch
2 times, most recently
from
7c51a08 to
e22379b
Compare
xorye
reviewed
Jun 11, 2020
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/dom/SchemaLocationHint.java
Outdated
Show resolved
Hide resolved
xorye
reviewed
Jun 11, 2020
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/dom/SchemaLocation.java
Outdated
Show resolved
Hide resolved
Every second token for the value of xsi:schemaLocation is turned into a document link to the referenced schema file. Closes eclipse-lemminx#666 Signed-off-by: David Thompson <[email protected]>
datho7561
force-pushed
the
doc-link-xsi-schema-location
branch
from
e22379b to
004dd13
Compare
|
+1 to merge it. @xorye if you are OK please do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every second token for the value of xsi:schemaLocation is turned into a
document link to the referenced schema file.
Closes #666
Signed-off-by: David Thompson [email protected]