-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create EntityNotDeclared code action #724
Conversation
...se/lemminx/extensions/contentmodel/participants/codeactions/EntityNotDeclaredCodeAction.java
Show resolved
Hide resolved
...se/lemminx/extensions/contentmodel/participants/codeactions/EntityNotDeclaredCodeAction.java
Outdated
Show resolved
Hide resolved
...se/lemminx/extensions/contentmodel/participants/codeactions/EntityNotDeclaredCodeAction.java
Outdated
Show resolved
Hide resolved
...se.lemminx/src/test/java/org/eclipse/lemminx/extensions/contentmodel/DTDDiagnosticsTest.java
Show resolved
Hide resolved
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/dom/DOMDocument.java
Outdated
Show resolved
Hide resolved
...se/lemminx/extensions/contentmodel/participants/codeactions/EntityNotDeclaredCodeAction.java
Outdated
Show resolved
Hide resolved
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/dom/DOMDocumentType.java
Outdated
Show resolved
Hide resolved
...se/lemminx/extensions/contentmodel/participants/codeactions/EntityNotDeclaredCodeAction.java
Show resolved
Hide resolved
please rebase against master |
Thank you, fixed |
...se/lemminx/extensions/contentmodel/participants/codeactions/EntityNotDeclaredCodeAction.java
Outdated
Show resolved
Hide resolved
...se/lemminx/extensions/contentmodel/participants/codeactions/EntityNotDeclaredCodeAction.java
Show resolved
Hide resolved
...se/lemminx/extensions/contentmodel/participants/codeactions/EntityNotDeclaredCodeAction.java
Outdated
Show resolved
Hide resolved
...se/lemminx/extensions/contentmodel/participants/codeactions/EntityNotDeclaredCodeAction.java
Show resolved
Hide resolved
...se/lemminx/extensions/contentmodel/participants/codeactions/EntityNotDeclaredCodeAction.java
Show resolved
Hide resolved
Fixed, I also added a second commit that adds tests for #686, since that issue is being fixed thanks to this new method: |
org.eclipse.lemminx/src/main/resources/org/eclipse/lemminx/services/snippets/pi-snippets.json
Outdated
Show resolved
Hide resolved
Signed-off-by: David Kwon <[email protected]>
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/utils/StringUtils.java
Outdated
Show resolved
Hide resolved
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/utils/StringUtils.java
Outdated
Show resolved
Hide resolved
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/utils/StringUtils.java
Outdated
Show resolved
Hide resolved
Great feedback, fixed |
Signed-off-by: David Kwon <[email protected]>
Thanks @fbricon |
Great PR @xorye ! |
Fixes #532
This PR adds a new code action to locally declare an undeclared entity.
Demo:
The codeaction works whether or not
<!DOCTYPE
is declared or not, and whether the internal subset[]
exists or not.Signed-off-by: David Kwon [email protected]