Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disallowDocTypeDecl & resolveExternalEntities validation settings #566

Merged
merged 1 commit into from
Oct 8, 2019

Conversation

angelozerr
Copy link
Contributor

Add disallowDocTypeDecl & resolveExternalEntities validation settings.

Signed-off-by: azerr [email protected]

@angelozerr
Copy link
Contributor Author

Please use the PR from vscode-xml redhat-developer/vscode-xml#187 to customize the 2 settings.

" <!ELEMENT \r\n" + //
"]>\r\n" + //
"<student />";
testDiagnosticsDisallowDocTypeDecl(xml, d(1, 0, 3, 2, XMLSyntaxErrorCode.DoctypeNotAllowed));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

severity should be configurable

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or not...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Today none severity can be configured because there are so many error code.

@fbricon fbricon merged commit d172c4d into master Oct 8, 2019
@angelozerr angelozerr added this to the v0.9.1 milestone Oct 9, 2019
@angelozerr angelozerr self-assigned this Oct 9, 2019
@angelozerr angelozerr deleted the entities-settings branch October 17, 2019 13:20
@fbricon fbricon changed the title Add disallowDocTypeDecl & resolveExternalEntities validation settings. Add disallowDocTypeDecl & resolveExternalEntities validation settings Oct 17, 2019
@fbricon
Copy link
Contributor

fbricon commented Oct 23, 2019

CVE-2019-18213 was opened about this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants