Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for textDocument/references for DTD #555

Merged
merged 1 commit into from
Aug 16, 2019
Merged

Conversation

angelozerr
Copy link
Contributor

Fixes #234

Signed-off-by: azerr [email protected]

@NikolasKomonen
Copy link
Contributor

@angelozerr If I try to peek a reference of a value that is not the definition I don't get any references.

eg:

<!ELEMENT font-fa|ce (X) > <-- peek references here gives the ATTLIST font-face reference
<!ATTLIST font-fa|ce >  <-- peek references here gives no references

Not sure if that is a design choice.

Otherwise, everything else works great.

@angelozerr
Copy link
Contributor Author

angelozerr commented Aug 14, 2019

<!ATTLIST font-face is linked to <!ELEMENT font-face (you can check that with definition on ATTLIST font-face. So if you find references from <!ELEMENT font-face you should see linked <!ATTLIST font-face.

Not sure if that is a design choice.

yes it's a choice, it's like references from java field.

@NikolasKomonen
Copy link
Contributor

@angelozerr I understand that, but if I do peek definition on <!ATTLIST font-face> no options appear.

@angelozerr
Copy link
Contributor Author

You should. If I test with svg.dtd, definition from <!ATTLIST font-face to <!ELEMENT font-face is working?

@angelozerr angelozerr merged commit 5886193 into master Aug 16, 2019
@angelozerr
Copy link
Contributor Author

Thanks @NikolasKomonen for your review, please create an issue with missing feature.

@angelozerr angelozerr deleted the dtd-references branch August 16, 2019 17:37
@angelozerr angelozerr restored the dtd-references branch August 17, 2019 17:33
@angelozerr angelozerr deleted the dtd-references branch August 17, 2019 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for textDocument/references for DTD
2 participants