Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hover markup kind response ignores the hover client capability #527

Merged
merged 1 commit into from
Jul 22, 2019

Conversation

angelozerr
Copy link
Contributor

Fix #525

Signed-off-by: azerr [email protected]

@angelozerr
Copy link
Contributor Author

angelozerr commented Jul 22, 2019

This PR gives the capability to check client capability for hover to returns MARKDOWN markup kind if client support it.

This PR

  • rename CompletionSettings to XMLCompletionSettings to follow the same rules than other settings.
  • fix bug to get folding client capability

@angelozerr angelozerr changed the title Hover markup kind response doesn't take care of client capability Hover markup kind response ignores the hover client capability Jul 22, 2019
@angelozerr angelozerr force-pushed the markdown-hover-capability branch from 2a50ea9 to 20c3819 Compare July 22, 2019 10:24
@angelozerr angelozerr force-pushed the markdown-hover-capability branch 2 times, most recently from af58dc2 to b2a37e6 Compare July 22, 2019 20:28
@angelozerr angelozerr force-pushed the markdown-hover-capability branch from b2a37e6 to f2a9319 Compare July 22, 2019 20:29
@angelozerr angelozerr merged commit abc006a into master Jul 22, 2019
@angelozerr angelozerr deleted the markdown-hover-capability branch July 22, 2019 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hover markup response ignored the hover client capability
2 participants