Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documents with an Internal Subset DOCTYPE shouldn't stop trying to bind #519

Merged
merged 1 commit into from
Jul 18, 2019

Conversation

angelozerr
Copy link
Contributor

Fix #379

Signed-off-by: azerr [email protected]

@angelozerr
Copy link
Contributor Author

To check this PR, create XML file like this:

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE article [
  <!ENTITY nbsp "entity-value">

]>           
<article>
	&nbsp;
</article>

It should not have error (this is the fix of the PR)

Declare an <!ELEMENT like this:

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE article [
  <!ENTITY nbsp "entity-value">
  <!ELEMENT element-name (#PCDATA)>
]>           
<article>
	&nbsp;
</article>

It should have error.

Change element-name to article to fix error:

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE article [
  <!ENTITY nbsp "entity-value">
  <!ELEMENT article (#PCDATA)>
]>           
<article>
	&nbsp;
</article>

@angelozerr angelozerr force-pushed the doctype-breaks-validation branch from 4ac40a2 to 15c2b15 Compare July 18, 2019 08:13
@angelozerr angelozerr force-pushed the doctype-breaks-validation branch from 15c2b15 to 0e35bc3 Compare July 18, 2019 08:21
@fbricon
Copy link
Contributor

fbricon commented Jul 18, 2019

It works but the validation error range is off
Screen Shot 2019-07-18 at 10 47 28 AM
Screen Shot 2019-07-18 at 10 49 49 AM

@angelozerr
Copy link
Contributor Author

Indeed I discovered this problem yesterday, I created an issue yesterday #518 and @xorye should work on it.

@angelozerr angelozerr merged commit 67b93ac into master Jul 18, 2019
@angelozerr
Copy link
Contributor Author

@fbricon I merged this PR since test passed and your test is OK. I need this PR to rebase my work with XSD 1.1. For error range please see #518

@angelozerr angelozerr deleted the doctype-breaks-validation branch July 18, 2019 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documents with an Internal Subset DOCTYPE had stopped trying to bind
2 participants