Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix src-element.3 error range #441

Merged
merged 1 commit into from
Jun 17, 2019
Merged

Fix src-element.3 error range #441

merged 1 commit into from
Jun 17, 2019

Conversation

xorye
Copy link

@xorye xorye commented Jun 14, 2019

Fixes #420

Upon looking at how this error is handled in IntelliJ and Eclipse, this is what I found:

IntelliJ
For xsd, there is no error
For xml, there is an error on the b tag name

Eclipse
For xsd, the error is on the whole line that contains <xs:element name="a" type="xs:integer">
For xml, there is no error.

This fix displays an error for both xsd and xml.

The error ranges look like the following:
xml:
image

xsd:
image

Signed-off-by: David Kwon [email protected]

@angelozerr angelozerr merged commit 39fc1fc into eclipse-lemminx:master Jun 17, 2019
@angelozerr
Copy link
Contributor

Thanks @xorye for your fix, it's perfect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixed error range for src-element.3
3 participants