Fix error range for p-props-correct.2.1 #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Kwon <[email protected]>
|
I love this kind of PR which is easy to test, the explanation is very good and commit comment is perfect. Thank's @xorye ! |
datho7561
added a commit
to datho7561/lemminx
that referenced
this pull request
Mar 24, 2021
Closes eclipse-lemminx#440 Signed-off-by: David Thompson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #436
There were three arguments provided by xerces:
arguments[0] = "element"(from<xs:element)arguments[1] = XInt(1)(value ofminOccurs)arguments[2] = XInt(0)(value ofmaxOccurs)The location given by xerces is the location of the element with the error.
Signed-off-by: David Kwon [email protected]