Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preference 'xml.symbols.exclude' for an array of patterns to exclude symbols for file(s) #432

Merged
merged 1 commit into from
Jun 14, 2019
Merged

Preference 'xml.symbols.exclude' for an array of patterns to exclude symbols for file(s) #432

merged 1 commit into from
Jun 14, 2019

Conversation

NikolasKomonen
Copy link
Contributor

No tests yet

The structure of this PR.

So for the patterns it will take in an array of patterns as strings.
The server will convert those patterns to XMLExcludedSymbolFiles classes.

Each TextDocument has a doSymbols Boolean.
When symbols is requested on it it will check if that Boolean has been set yet, or else it will compute a pattern match.

Let me know if this works or could be improved.

@NikolasKomonen
Copy link
Contributor Author

NikolasKomonen commented Jun 12, 2019 •
edited
Loading

@angelozerr Are you fine with this implementation. I put a quick explanation at the top.

@fbricon fbricon requested a review from angelozerr June 12, 2019 21:51
@NikolasKomonen NikolasKomonen force-pushed the symbolFilePreference branch 3 times, most recently from a972d27 to cead206 Compare June 13, 2019 16:11
@NikolasKomonen
Copy link
Contributor Author

@angelozerr I've updated the PR with your changes. I created the PathPatternMatcher class and refactored the code.

@angelozerr
Copy link
Contributor

@angelozerr I've updated the PR with your changes. I created the PathPatternMatcher class and refactored the code.

Thanks @NikolasKomonen ! Now the code is perfect. Do you think you could write a test with XMLSymbolSettings#isExcluded method? After that I'm OK to merge it.

@NikolasKomonen
Copy link
Contributor Author

@angelozerr I've updated the pr with tests and javadocs. Could you check it and let me know if I need to add more.

@angelozerr angelozerr merged commit c4c4ce8 into eclipse-lemminx:master Jun 14, 2019
@angelozerr
Copy link
Contributor

@angelozerr I've updated the pr with tests and javadocs. Could you check it and let me know if I need to add more.

It's perfect, thank's @NikolasKomonen !

@angelozerr angelozerr mentioned this pull request Jun 14, 2019
Closed
@angelozerr angelozerr mentioned this pull request Oct 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelozerr angelozerr angelozerr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NikolasKomonen @angelozerr