Preference to turn off document symbols #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikolasKomonen
force-pushed
the
documentSymbolPreference
branch
2 times, most recently
from
946ef8e to
c167d0d
Compare
fbricon
reviewed
Jun 4, 2019
| @@ -215,6 +216,11 @@ private XMLFormattingOptions getFormattingSettings(String uri) { | |||
| @Override | |||
| public CompletableFuture<List<Either<SymbolInformation, DocumentSymbol>>> documentSymbol( | |||
| DocumentSymbolParams params) { | |||
|
|
|||
| if(!sharedSettings.symbolSettings.isEnabled()) { | |||
| return CompletableFuture.completedFuture(null); | |||
There was a problem hiding this comment.
CompletableFuture.completedFuture(Collections.emptyList());
else, you might break some clients
Fixes eclipse-lemminx#413 Signed-off-by: Nikolas Komonen <[email protected]>
NikolasKomonen
force-pushed
the
documentSymbolPreference
branch
from
c167d0d to
8cee65c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #413