Fix completion source crash in Windows OS #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since source was added in completion, completion doesn't work on Windows OS because of use of Path.getPaths to retreive the file name. For instance: here the error on Window OS ``` java.nio.file.InvalidPathException: Illegal char <:> at index 4: file:/C:/Users/azerr/.lsp4xml/cache/https/www.w3.org/1999/11/xslt10.xsd at java.base/sun.nio.fs.WindowsPathParser.normalize(WindowsPathParser.java:182) at java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:153) at java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:77) at java.base/sun.nio.fs.WindowsPath.parse(WindowsPath.java:92) at java.base/sun.nio.fs.WindowsFileSystem.getPath(WindowsFileSystem.java:229) at java.base/java.nio.file.Path.of(Path.java:147) at java.base/java.nio.file.Paths.get(Paths.java:69) ``` This PR fixes this bug on Wondows OS by avoiding using Paths.getPath to retrieve the file name. I have too cleaned a little the code of generateDocumentation.
|
@NikolasKomonen @fbricon @xorye please review and merge this PR on master because on Windows OS, completion is broken. |
|
@angelozerr works well for me. I can merge it. Could you explain the problem with Paths.getPath() since I am using it for Path completion in another PR? |
See the stack trace, in Windows OS, the schemaURI is called with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since source was added in completion, completion doesn't work on Windows OS because of use of Path.getPaths to retreive the file name.
For instance: here the error on Window OS
This PR fixes this bug on Wondows OS by avoiding using Paths.getPath to retrieve the file name. I have too cleaned a little the code of generateDocumentation.