Indicate source of element for completion #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thoughts on the final result, any preferences for me to change anything? Will do tests once the implementation is confirmed. |
NikolasKomonen
force-pushed
the
completionLabelXSDDTD
branch
from
adbedd8 to
82c7ea6
Compare
fbricon
requested changes
May 27, 2019
.../eclipse/lsp4xml/extensions/contentmodel/participants/ContentModelCompletionParticipant.java
Outdated
Show resolved
Hide resolved
.../eclipse/lsp4xml/extensions/contentmodel/participants/ContentModelCompletionParticipant.java
Outdated
Show resolved
Hide resolved
.../eclipse/lsp4xml/extensions/contentmodel/participants/ContentModelCompletionParticipant.java
Outdated
Show resolved
Hide resolved
.../eclipse/lsp4xml/extensions/contentmodel/participants/ContentModelCompletionParticipant.java
Outdated
Show resolved
Hide resolved
.../eclipse/lsp4xml/extensions/contentmodel/participants/ContentModelCompletionParticipant.java
Outdated
Show resolved
Hide resolved
|
Missing unit tests for xsd and dtd sources |
|
Overall it looks pretty good (using Source: instead of File:) |
angelozerr
reviewed
May 27, 2019
...ipse.lsp4xml/src/main/java/org/eclipse/lsp4xml/extensions/contentmodel/model/CMDocument.java
Outdated
Show resolved
Hide resolved
fbricon
changed the title
NikolasKomonen
changed the title
NikolasKomonen
force-pushed
the
completionLabelXSDDTD
branch
2 times, most recently
from
43f896c to
214a197
Compare
|
@fbricon Updated with tests, now 'Source' is used instead of 'File' and the file URI is provided in the constructor as @angelozerr indicated. |
fbricon
requested changes
May 27, 2019
...pse.lsp4xml/src/main/java/org/eclipse/lsp4xml/extensions/xsd/contentmodel/CMXSDDocument.java
Show resolved
Hide resolved
|
Please fix the conflict with master |
fbricon
reviewed
May 27, 2019
fbricon
reviewed
May 27, 2019
...src/main/java/org/eclipse/lsp4xml/extensions/xsd/contentmodel/CMXSDContentModelProvider.java
Outdated
Show resolved
Hide resolved
fbricon
reviewed
May 27, 2019
...pse.lsp4xml/src/main/java/org/eclipse/lsp4xml/extensions/dtd/contentmodel/CMDTDDocument.java
Outdated
Show resolved
Hide resolved
fbricon
reviewed
May 27, 2019
...pse.lsp4xml/src/main/java/org/eclipse/lsp4xml/extensions/dtd/contentmodel/CMDTDDocument.java
Outdated
Show resolved
Hide resolved
fbricon
reviewed
May 27, 2019
.../eclipse/lsp4xml/extensions/contentmodel/participants/ContentModelCompletionParticipant.java
Outdated
Show resolved
Hide resolved
fbricon
reviewed
May 27, 2019
.../eclipse/lsp4xml/extensions/contentmodel/participants/ContentModelCompletionParticipant.java
Outdated
Show resolved
Hide resolved
the file name of the schema they come from. Fixes eclipse-lemminx#210 Signed-off-by: Nikolas Komonen <[email protected]>
NikolasKomonen
force-pushed
the
completionLabelXSDDTD
branch
from
214a197 to
8326fbf
Compare
|
@fbricon Updated |
fbricon
approved these changes
May 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #210
Example with A description and filename