Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache unavailable URI's #275

Merged
merged 1 commit into from
Jan 25, 2019
Merged

Cache unavailable URI's #275

merged 1 commit into from
Jan 25, 2019
+319 −16

Conversation

NikolasKomonen
Copy link
Contributor

Fixes #201

Tests aren't complete, need to find a way to handle exceptions.

@angelozerr
Copy link
Contributor

I have just few questions about this PR:

@fbricon
Copy link
Contributor

fbricon commented Jan 8, 2019

Caffeine is a high performance caching library. Its use has already been approved by the Eclipse Foundation, so IP is not an issue.
But actually, for our use case, with an extremely small number of urls to cache, we probably can just stick with the default Cache from guava, that we already embed and which has the same API.
Just replace the Caffeine.newBuilder() call with CacheBuilder.newBuilder().

@NikolasKomonen
Cache unavailable URI's
55078ec 
Fixes eclipse-lemminx#201

Signed-off-by: Nikolas Komonen <[email protected]>
@NikolasKomonen
Copy link
Contributor Author

@fbricon updated with the jetty pr

@fbricon fbricon merged commit 1725db2 into eclipse-lemminx:master Jan 25, 2019
@NikolasKomonen NikolasKomonen deleted the cache branch March 7, 2019 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbricon fbricon fbricon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NikolasKomonen @angelozerr @fbricon