Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hover show documentation for XSI attributes #240

Merged
merged 1 commit into from
Dec 4, 2018
Merged

Hover show documentation for XSI attributes #240

merged 1 commit into from
Dec 4, 2018

Conversation

NikolasKomonen
Copy link
Contributor

@NikolasKomonen NikolasKomonen commented Nov 29, 2018 •
edited
Loading

Fixes #164 and #247

@NikolasKomonen
Copy link
Contributor Author

@fbricon updated

fbricon
fbricon requested changes Nov 29, 2018
View reviewed changes
Copy link
Contributor

@fbricon fbricon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with this sample from https://www.liquid-technologies.com/xml-schema-tutorial/xsd-extending-types:

<?xml version="1.0" ?>
<Person xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"> 
    <Name>Fred</Name> 
    <HomeAddress xsi:type="USAddressType"> 
        <Line1>234 Lancaseter Av</Line1> 
        <Line2>SmallsVille</Line2> 
        <State>Florida</State> 
        <Zipcode>34543</Zipcode> 
    </HomeAddress> 
</Person>

got nothing hovering over xsi:type

@NikolasKomonen NikolasKomonen changed the title Hover show documentation for XSI Hover show documentation for XSI attributes Nov 30, 2018
@NikolasKomonen
Copy link
Contributor Author

@fbricon updated

@angelozerr angelozerr mentioned this pull request Dec 3, 2018
Closed
@NikolasKomonen NikolasKomonen force-pushed the hoverXSI branch 4 times, most recently from 2040186 to e97f12a Compare December 4, 2018 20:33
@NikolasKomonen
Copy link
Contributor Author

@fbricon updated

@NikolasKomonen
Copy link
Contributor Author

@fbricon updated

@fbricon fbricon merged commit 864ab31 into eclipse-lemminx:master Dec 4, 2018
@NikolasKomonen NikolasKomonen deleted the hoverXSI branch January 23, 2019 19:37
@xorye xorye mentioned this pull request May 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelozerr angelozerr angelozerr left review comments

@fbricon fbricon fbricon requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NikolasKomonen @fbricon @angelozerr