DTD losing content on format fixed #200
Conversation
NikolasKomonen
force-pushed
the
dtdFormattingFix
branch
from
63116b7 to
a8c1f9f
Compare
| @Test | ||
| public void testDTDFormattingInternal() throws BadLocationException { | ||
| String content = | ||
| "<?xml version=\"1.0\"?>" + lineSeparator() + |
There was a problem hiding this comment.
Please don't use lineSeparator() because your tests depends on OS. Please use \r or \ r\n.
If you use Eclipse to develop Java, you can copy a content of XML file and go to the Java Editor code. Type just "" and copy/paste the pasted XML content inside the "". Java Editor JDT will manage \r
There was a problem hiding this comment.
I though \r\n was specific to Windows, do you know why it works for me on linux when I run tests using \r\n?
There was a problem hiding this comment.
Sorry with my bad explanation.
I though \r\n was specific to Windows,
Yes it is.
I meant that we have tests which is not linked to an OS. So in your Linux case, you will havelineSparatator= \r and in my OS Windows case, I will have lineSparatator=\r\n So the offset will be different.
I agree with you, your test doesn't use offset so we will hav eno problem, but it should be more clean to have tests which hard coded the line separator.
Hope you will understand my explanation.
|
Very cool PR @NikolasKomonen ! IMHO, I think it should really cool if we could use your scanner to manage in XMLDocument, the Entity to display it in the Outline, manage completion, etc |
@angelozerr yes! Thats what I was hoping we could eventually work on. This pr is just temporary to make sure DTD content doesn't disappear. |
Great! |
|
PR fixes the issues. @NikolasKomonen fix the line endings and we can merge it |
NikolasKomonen
force-pushed
the
dtdFormattingFix
branch
from
a8c1f9f to
379e05f
Compare
|
@fbricon line endings fixed |
Fixes #198