Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatted node content doesnt get touched #156

Merged
merged 1 commit into from
Oct 9, 2018

Conversation

NikolasKomonen
Copy link
Contributor

Fixes #152

@NikolasKomonen NikolasKomonen force-pushed the formatErrorFixes branch 2 times, most recently from 5aa61b7 to 5692f64 Compare October 5, 2018 19:11
@@ -370,8 +370,7 @@ private void createPrologCompletionSuggestion(int tagNameEnd, String tag, Comple
Range editRange = getReplaceRange(tagNameEnd, end, request);
item.setTextEdit(new TextEdit(editRange, " version=\"1.0\" encoding=\"UTF-8\"?" + closeTag + "$0"));
} catch (BadLocationException e) {
// TODO Auto-generated catch block
e.printStackTrace();
LOGGER.log(Level.SEVERE, "While performing getReplaceRange for prolog completion.", e);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this code which is not part in this issue (I have already fixed and it will resolve conflict).

@NikolasKomonen
Copy link
Contributor Author

@angelozerr updated.

@angelozerr angelozerr merged commit 6bd29e7 into eclipse-lemminx:master Oct 9, 2018
@angelozerr
Copy link
Contributor

Thanks @NikolasKomonen !

@NikolasKomonen NikolasKomonen deleted the formatErrorFixes branch January 22, 2019 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants