Bump lsp4j.version from 0.20.1 to 0.21.0 #1529
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
the
dependencies
dependabot
bot
force-pushed
the
dependabot/maven/lsp4j.version-0.21.0
branch
from
6e56670 to
cb140dd
Compare
|
@dependabot rebase |
Bumps `lsp4j.version` from 0.20.1 to 0.21.0. Updates `org.eclipse.lsp4j` from 0.20.1 to 0.21.0 - [Release notes](https://github.com/eclipse-lsp4j/lsp4j/releases) - [Changelog](https://github.com/eclipse-lsp4j/lsp4j/blob/main/CHANGELOG.md) - [Commits](eclipse-lsp4j/lsp4j@v0.20.1...v0.21.0) Updates `org.eclipse.lsp4j.jsonrpc` from 0.20.1 to 0.21.0 - [Release notes](https://github.com/eclipse-lsp4j/lsp4j/releases) - [Changelog](https://github.com/eclipse-lsp4j/lsp4j/blob/main/CHANGELOG.md) - [Commits](eclipse-lsp4j/lsp4j@v0.20.1...v0.21.0) --- updated-dependencies: - dependency-name: org.eclipse.lsp4j:org.eclipse.lsp4j dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.eclipse.lsp4j:org.eclipse.lsp4j.jsonrpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/maven/lsp4j.version-0.21.0
branch
from
cb140dd to
2fa69a1
Compare
|
@vrubezhny please take care of lsp4j version for binary |
lsp4j, probably, cannot be updated to 0.21.0 right now: means that this version is built with Java 11 and incompatible with Java 8 used in Lemminx, so, Lemminx is to be moved to this Java version in order to update to this version. I believe move to Java 17 is more preferable. |
|
Yes please and we need to check if there are some new classes to declare them in reflect json file used by binary. What do you think @fbricon @datho7561 @rgrunber to swith to java 17 since now we have binary. We need to check to the binary build continue to work with java 17 |
|
We have binaries for linux-x64, win32-x64, darwin-x64, darwin-arm64 . VS Code supports win32-x64, win32-ia32, win32-arm64, linux-x64, linux-arm64, linux-armhf, alpine-x64, alpine-arm64, darwin-x64, darwin-arm64 and web So users on win32-ia32, win32-arm64, linux-arm64, linux-armhf, alpine-x64, alpine-arm64, web would not get the binary. I guess the question is are there users on these unsupported (for binary) platforms that would have a JRE 1.8 and not anything higher ? Are we ok with this slight imposition on those platforms. We could finally fix #1291 if we moved to Java 11 😂 |
|
For Alpine Linux: openjdk11 and openjdk17 both appear to be packaged for the distro in x86_64 and 64bit ARM. It looks like there is an Eclipse Temurin release for 64bit ARM for Linux (I'm assuming it's for glibc-based Linux since it doesn't say) That leaves: win32-ia32, win32-arm64, linux-armhf (I couldn't find a Temurin release for Windows ARM) |
Maybe it's not a problem，See https://marketplace.visualstudio.com/items?itemName=vscjava.vscode-java-pack ,it required "📦 Language Support for Java™ by Red Hat",Then see https://marketplace.visualstudio.com/items?itemName=redhat.java#setting-the-jdk ,it will embed a JRE for supported platforms such as win32-x64, linux-x64, linux-arm64, darwin-x64, darwin-arm64.and bellow they say "Java 17 is the minimum required version.",Same to see "java.jdt.ls.java.home" description in "https://github.com/redhat-developer/vscode-java/blob/master/package.json" , Java 17 is specified. |
|
The main issue we are facing is that many of the people who want to edit XML don't want to install Java (see some of the older comments on the marketplace), so they likely won't have vscode-java installed. Anyone using one of the more obscure architectures that we don't provide a binary for will have to use a Java 17 JDK (or 11? I don't think we necessarily need to go to 17) in order to run vscode-xml. That means any architecture that doesn't have a Java 17 version can't run the extension. To me, it seems like most systems with JDK 8 also have JDK 17, so we won't be cutting off many people from running the extension. |
|
Superseded by #1578. |
Sorry to revisit the issue again. |
|
The decision to go to a minimum of Java 11 will happen soon. https://github.com/eclipse/lemminx/pull/1607/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R15 |
Will the minimum Java go to 11 anytime soon @rgrunber ? I need this CVE related to guava and the lsp4j version to get resolved. I opened issue #1546 a year and a half ago for it. |
Bumps
lsp4j.versionfrom 0.20.1 to 0.21.0.Updates
org.eclipse.lsp4jfrom 0.20.1 to 0.21.0Release notes
Sourced from org.eclipse.lsp4j's releases.
... (truncated)
Changelog
Sourced from org.eclipse.lsp4j's changelog.
Commits
2540cd3Prepare repo for 0.21.0 release87b6d76Update docs for 0.21.0 release79df5e2Void return types need to always be null value3d55fa0Fix typo in test name7040d87Add missing quotes around body in JSONa526054Wrap primitive and array parameter into an array as in JSON-RPC 2.0ac1bfd5Add 0.19.1 to main changelogd9ccef3Bring DAP protocol implemented up to 1.60.03838d20Add support for startDebugging1381d0fUpdate all URLs for new LSP4J GitHub orgUpdates
org.eclipse.lsp4j.jsonrpcfrom 0.20.1 to 0.21.0Release notes
Sourced from org.eclipse.lsp4j.jsonrpc's releases.
... (truncated)
Changelog
Sourced from org.eclipse.lsp4j.jsonrpc's changelog.
Commits
2540cd3Prepare repo for 0.21.0 release87b6d76Update docs for 0.21.0 release79df5e2Void return types need to always be null value3d55fa0Fix typo in test name7040d87Add missing quotes around body in JSONa526054Wrap primitive and array parameter into an array as in JSON-RPC 2.0ac1bfd5Add 0.19.1 to main changelogd9ccef3Bring DAP protocol implemented up to 1.60.03838d20Add support for startDebugging1381d0fUpdate all URLs for new LSP4J GitHub orgYou can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)