Report grammar identifier to didOpen telemetry events. #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrunber
commented
Aug 23, 2021
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/telemetry/DocumentTelemetryInfo.java
Show resolved
Hide resolved
angelozerr
reviewed
Aug 27, 2021
| for (ReferencedGrammarInfo info : referencedGrammarInfos) { | ||
| String kind = info.getBindingKind() == null ? "none" : info.getBindingKind(); | ||
| String resolver = info.getResolvedBy(); | ||
| String identifier = info.getIdentifierURI(); | ||
| if ("xml".equals(fileExtension)) { |
There was a problem hiding this comment.
the "xml".equals(fileExtension) should be replaced with a boolean
boolean isXML = !DOMUtils.isXSD(document) && !DOMUtils.isDTD(document);
because you can have another extension for xml.
There was a problem hiding this comment.
There was also a second reference above. Should be fixed now.
- Fixes eclipse-lemminx#1105 - Do not report local grammars - When exactly 1 grammar reference exists per file, simply send the relevant values (not a list of size 1). Otherwise, send the values as a list Signed-off-by: Roland Grunberg <[email protected]>
|
Thanks @rgrunber |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relevant values (not a list of size 1). Otherwise, send the values as
a list
Signed-off-by: Roland Grunberg [email protected]