Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed src-import.3.2 XSD error highlighting support #1087

Merged
merged 1 commit into from
Jul 20, 2021
Merged

fixed src-import.3.2 XSD error highlighting support #1087

merged 1 commit into from
Jul 20, 2021

Conversation

AlexXuChen
Copy link
Contributor

Fixed the src-import.3.2 XSD error highlighting support to highlight the xs:import schemaLocation attribute.

Closes #1069

Signed-off-by: Alexander Chen [email protected]

@datho7561 datho7561 self-requested a review July 20, 2021 19:13
datho7561
datho7561 approved these changes Jul 20, 2021
View reviewed changes
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@datho7561 datho7561 merged commit 0007ad4 into eclipse-lemminx:master Jul 20, 2021
@AlexXuChen AlexXuChen deleted the issue1069 branch July 20, 2021 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datho7561 datho7561 datho7561 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect error range for src-import.3.2
2 participants
@AlexXuChen @datho7561