-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bind XSD, DTD with CodeLens #1049
Bind XSD, DTD with CodeLens #1049
Conversation
@BoykoAlex pay attention this PR will break the API of command (IDelegateCommandHandler). Now we will have the shared settings in the parameter: public interface IDelegateCommandHandler {
/**
* Executes a command
*
* @param params command execution parameters
* @param sharedSettings the shared settings.
* @param cancelChecker check if cancel has been requested
* @return the result of the command
* @throws Exception the unhandled exception will be wrapped in
* <code>org.eclipse.lsp4j.jsonrpc.ResponseErrorException</code>
* and be wired back to the JSON-RPC protocol caller
*/
Object executeCommand(ExecuteCommandParams params, SharedSettings sharedSettings, CancelChecker cancelChecker) throws Exception;
} |
769daea
to
d3f5f4c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks pretty good and it works great!
I think we should add a file in docs/
that explains what the client needs to implement in order to support these CodeLens properly.
It would be nice if the code actions that add the XML to bind to the schema respected the formatting settings, but this could be handled in a different PR.
.../main/java/org/eclipse/lemminx/extensions/contentmodel/commands/AssociateGrammarCommand.java
Show resolved
Hide resolved
.../main/java/org/eclipse/lemminx/extensions/contentmodel/commands/AssociateGrammarCommand.java
Outdated
Show resolved
Hide resolved
.../main/java/org/eclipse/lemminx/extensions/contentmodel/commands/AssociateGrammarCommand.java
Outdated
Show resolved
Hide resolved
.../main/java/org/eclipse/lemminx/extensions/contentmodel/commands/AssociateGrammarCommand.java
Outdated
Show resolved
Hide resolved
...rg/eclipse/lemminx/extensions/contentmodel/participants/ContentModelCodeLensParticipant.java
Show resolved
Hide resolved
...lemminx/extensions/contentmodel/participants/codeactions/NoGrammarConstraintsCodeAction.java
Show resolved
Hide resolved
...lemminx/extensions/contentmodel/participants/codeactions/NoGrammarConstraintsCodeAction.java
Show resolved
Hide resolved
c271d41
to
ae97315
Compare
.../main/java/org/eclipse/lemminx/extensions/contentmodel/commands/AssociateGrammarCommand.java
Outdated
Show resolved
Hide resolved
.../main/java/org/eclipse/lemminx/extensions/contentmodel/commands/AssociateGrammarCommand.java
Outdated
Show resolved
Hide resolved
...java/org/eclipse/lemminx/extensions/contentmodel/AssociateGrammarCodeLensExtensionsTest.java
Show resolved
Hide resolved
...t/java/org/eclipse/lemminx/extensions/contentmodel/commands/AssociateGrammarCommandTest.java
Show resolved
Hide resolved
ae97315
to
f9376d0
Compare
See redhat-developer/vscode-xml#395 Signed-off-by: azerr <[email protected]>
Bind XSD, DTD with CodeLens
See redhat-developer/vscode-xml#395
Signed-off-by: azerr [email protected]