Fix ability to disable "no grammar" message #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datho7561
force-pushed
the
467-fix-no-grammar-disable
branch
from
565d40e to
c40f87f
Compare
|
Can we have unit tests that check there won't be another regression in the future pretty please? |
datho7561
force-pushed
the
467-fix-no-grammar-disable
branch
from
c40f87f to
e36dbe5
Compare
|
I don't know how to effectively unit test this scenario, but I attached an attempt |
datho7561
force-pushed
the
467-fix-no-grammar-disable
branch
2 times, most recently
from
c01164b to
a653c63
Compare
fbricon
reviewed
May 6, 2021
...rc/main/java/org/eclipse/lemminx/extensions/contentmodel/settings/XMLValidationSettings.java
Outdated
Show resolved
Hide resolved
fbricon
reviewed
May 6, 2021
org.eclipse.lemminx/src/test/java/org/eclipse/lemminx/settings/SettingsMergeTest.java
Outdated
Show resolved
Hide resolved
fbricon
reviewed
May 6, 2021
org.eclipse.lemminx/src/test/java/org/eclipse/lemminx/settings/SettingsMergeTest.java
Outdated
Show resolved
Hide resolved
datho7561
force-pushed
the
467-fix-no-grammar-disable
branch
2 times, most recently
from
ee9c570 to
1a8c030
Compare
rgrunber
suggested changes
May 6, 2021
org.eclipse.lemminx/src/test/java/org/eclipse/lemminx/settings/SettingsMergeTest.java
Outdated
Show resolved
Hide resolved
org.eclipse.lemminx/src/test/java/org/eclipse/lemminx/settings/SettingsMergeTest.java
Outdated
Show resolved
Hide resolved
datho7561
force-pushed
the
467-fix-no-grammar-disable
branch
3 times, most recently
from
ba8ea79 to
00ee4bc
Compare
Fixes redhat-developer/vscode-xml#467 Signed-off-by: David Thompson <[email protected]>
datho7561
force-pushed
the
467-fix-no-grammar-disable
branch
from
00ee4bc to
506c401
Compare
|
I would just restore it to how it was before with the manual setting of methods and calling merge. No need for setAccessible(..). IMO, I think it's fine to merge. Anyone adding to validation settings should add to that testcase and they would catch any issues with merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes redhat-developer/vscode-xml#467
Signed-off-by: David Thompson [email protected]