Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DTD validation doesn't work with XML catalog and PUBLIC declaration #847

Closed
angelozerr opened this issue Aug 18, 2020 · 0 comments · Fixed by #848
Closed

DTD validation doesn't work with XML catalog and PUBLIC declaration #847

angelozerr opened this issue Aug 18, 2020 · 0 comments · Fixed by #848
Assignees
@angelozerr
Labels
bug Something isn't working catalog DTD validation
Milestone
0.14.0

Comments

@angelozerr
Copy link
Contributor

angelozerr commented Aug 18, 2020 •
edited
Loading

You have a lot of errors (because the DTD cannot be resolved):

image

Although you should have no errors like

image
@angelozerr angelozerr added bug Something isn't working catalog labels Aug 18, 2020
@angelozerr angelozerr self-assigned this Aug 18, 2020
angelozerr added a commit to angelozerr/lemminx that referenced this issue Aug 18, 2020
@angelozerr
DTD resolution doesn't work with XML catalog
c1b83f4 
Fixes eclipse-lemminx#847

Signed-off-by: azerr <[email protected]>
@angelozerr angelozerr mentioned this issue Aug 18, 2020
Merged
angelozerr added a commit to angelozerr/lemminx that referenced this issue Aug 20, 2020
@angelozerr
DTD validation doesn't work with XML catalog and PUBLIC declaration
f7fcd3d 
Fixes eclipse-lemminx#847

Signed-off-by: azerr <[email protected]>
@angelozerr angelozerr changed the title DTD resolution doesn't work with XML catalog DTD validation doesn't work with XML catalog and PUBLIC declaration Aug 20, 2020
angelozerr added a commit that referenced this issue Aug 20, 2020
@angelozerr
DTD validation doesn't work with XML catalog and PUBLIC declaration
ebb62a7 
Fixes #847

Signed-off-by: azerr <[email protected]>
@angelozerr angelozerr added this to the 0.13.2 milestone Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angelozerr angelozerr

Labels
bug Something isn't working catalog DTD validation
Projects
None yet
Milestone
0.14.0
Development

Successfully merging a pull request may close this issue.

DTD validation doesn't work with XML catalog and PUBLIC declaration angelozerr/lemminx
1 participant
@angelozerr