Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing the file associations or catalogs in the preferences should trigger validation #143

Closed
fbricon opened this issue Sep 25, 2018 · 5 comments
Closed

Changing the file associations or catalogs in the preferences should trigger validation #143

fbricon opened this issue Sep 25, 2018 · 5 comments
Assignees
@angelozerr
Labels
enhancement New feature or request in progress needs tests This issue is probably fixed but needs regression tests validation
Milestone
v0.3.0

Comments

@fbricon
Copy link
Contributor

fbricon commented Sep 25, 2018

When a file association or a catalog is added or modified in the preferences, if a matching document is already open, it doesn't take into account the new schema.
Either diagnostics on opened documents are stale or missing.
So changing associations or catalogs should trigger validation for all opened documents.
@fbricon fbricon added enhancement New feature or request validation labels Sep 25, 2018
@fbricon fbricon added this to the v0.0.3 milestone Nov 3, 2018
@angelozerr
Copy link
Contributor

Changing content of XML Schema/DTD should trigger too validation. We could start to trigger validation for all opened XML document and after we could improve it to validate only XML document which is linked to the XML Schema/DTD which changed.

@fbricon fbricon mentioned this issue Nov 9, 2018
Closed
angelozerr added a commit that referenced this issue Nov 9, 2018
@angelozerr
Refactor extension to use doSave instead of updateSettings (see #143)
2620f0a
@angelozerr angelozerr self-assigned this Nov 9, 2018
angelozerr added a commit that referenced this issue Nov 9, 2018
@angelozerr
Trigger validation when catalog/file associatiosn changed (see #143)
160418f
@angelozerr
Copy link
Contributor

It should work. We need to write tests.

@angelozerr
Copy link
Contributor

It should work now, please give me feedback.

@fbricon
Copy link
Contributor Author

fbricon commented Dec 5, 2018

I confirm this works. Do we have regression tests for that?

@fbricon fbricon added the needs tests This issue is probably fixed but needs regression tests label Dec 5, 2018
@angelozerr
Copy link
Contributor

No taht's why I have not closed it

NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Jan 18, 2019
@NikolasKomonen
Tests for fileAssociations updates
b24e41a 
Closes eclipse-lemminx#143

Signed-off-by: Nikolas <[email protected]>
@NikolasKomonen NikolasKomonen mentioned this issue Jan 18, 2019
Merged
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Jan 18, 2019
@NikolasKomonen
Tests for fileAssociations updates
8cf37a6 
Closes eclipse-lemminx#143

Signed-off-by: Nikolas <[email protected]>
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Jan 21, 2019
@NikolasKomonen
Tests for fileAssociations updates
51a123e 
Closes eclipse-lemminx#143

Signed-off-by: Nikolas <[email protected]>
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Jan 21, 2019
@NikolasKomonen
Tests for fileAssociations updates
e193157 
Closes eclipse-lemminx#143

Signed-off-by: Nikolas <[email protected]>
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Jan 22, 2019
@NikolasKomonen
Tests for fileAssociations updates
9c12f4c 
Closes eclipse-lemminx#143

Signed-off-by: Nikolas <[email protected]>
fbricon pushed a commit that referenced this issue Jan 23, 2019
@NikolasKomonen @fbricon
Tests for fileAssociations updates
92f7f65 
Closes #143

Signed-off-by: Nikolas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angelozerr angelozerr

Labels
enhancement New feature or request in progress needs tests This issue is probably fixed but needs regression tests validation
Projects
None yet
Milestone
v0.3.0
Development

No branches or pull requests
2 participants
@fbricon @angelozerr