Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeLens does not work in binary #1046

Closed
datho7561 opened this issue Jun 2, 2021 · 2 comments · Fixed by #1048
Closed

CodeLens does not work in binary #1046

datho7561 opened this issue Jun 2, 2021 · 2 comments · Fixed by #1048
Assignees
Labels
bug Something isn't working codelens reflection
Milestone

Comments

@datho7561
Copy link
Contributor

Example to replicate:

<?xml version="1.0" encoding="UTF-8"?>
<xs:schema xmlns:xs="http://www.w3.org/2001/XMLSchema">

  <!-- elements -->

  <xs:element name="root">
    <xs:complexType>
      <xs:sequence>
        <xs:element ref="container"/>
      </xs:sequence>
    </xs:complexType>
  </xs:element>

  <xs:element name="container" type="asdf" />

  <xs:element name="content" type="asdf" />

  <!-- types -->

  <xs:complexType name="asdf">
    <xs:sequence>
      <xs:element ref="content"/>
    </xs:sequence>
  </xs:complexType>

</xs:schema>

There should be Code Lens before the container and content element declarations, and the asdf type declaration.

Instead, the response that's returned is:

[Trace - 4:43:33 PM] Received response 'textDocument/codeLens - (35)' in 6ms.
Result: [
    {},
    {},
    {}
]
@datho7561 datho7561 added bug Something isn't working codelens reflection labels Jun 2, 2021
@angelozerr
Copy link
Contributor

It seems CodeLensRegistrationOptions is missing in JSON file. Is it the problem?

@datho7561
Copy link
Contributor Author

Yes, the registration options, and maybe some of the other lsp4j classes that get serialized, are not registered for reflection yet.

@datho7561 datho7561 self-assigned this Jun 3, 2021
datho7561 added a commit to datho7561/lemminx that referenced this issue Jun 3, 2021
datho7561 added a commit to datho7561/lemminx that referenced this issue Jun 3, 2021
@datho7561 datho7561 added this to the 0.17.0 milestone Jun 3, 2021
angelozerr pushed a commit that referenced this issue Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working codelens reflection
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants