Disable snippet in code action (see #185)

eclipse-lemminx · Nov 2, 2018 · 4b0db9c · 4b0db9c
1 parent 5da726f
commit 4b0db9c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/...4xml/extensions/contentmodel/participants/codeactions/cvc_complex_type_2_1CodeAction.java b/...4xml/extensions/contentmodel/participants/codeactions/cvc_complex_type_2_1CodeAction.java
@@ -47,7 +47,7 @@ public void doCodeAction(Diagnostic diagnostic, Range range, XMLDocument documen
 			}
 
 		} catch (BadLocationException e) {
-			// DO nothing
+			// Do nothing
 		}
 	}
 

diff --git a/...sp4xml/extensions/contentmodel/participants/codeactions/cvc_complex_type_4CodeAction.java b/...sp4xml/extensions/contentmodel/participants/codeactions/cvc_complex_type_4CodeAction.java
@@ -28,7 +28,7 @@
 import org.eclipse.lsp4xml.settings.XMLFormattingOptions;
 
 /**
- * Code action to fix cvc-complex-type.2.3 error.
+ * Code action to fix cvc-complex-type.4 error.
  *
  */
 public class cvc_complex_type_4CodeAction implements ICodeActionParticipant {
@@ -54,7 +54,9 @@ public void doCodeAction(Diagnostic diagnostic, Range range, XMLDocument documen
 					.filter(cmAttr -> !element.hasAttribute(cmAttr.getName())) //
 					.collect(Collectors.toList());
 
-			XMLGenerator generator = new XMLGenerator(null, "", "", true, 0);
+			// CodeAction doesn't support snippet -> https://github.com/Microsoft/language-server-protocol/issues/592
+			boolean supportSnippet = false;
+			XMLGenerator generator = new XMLGenerator(null, "", "", supportSnippet, 0);
 			String xmlAttributes = generator.generate(requiredAttributes, element.getTagName());
 
 			// Insert required attributes
-Original file line number
+Diff line change
@@ Expand Up @@
     			}
     		} catch (BadLocationException e) {
-    			// DO nothing
+    			// Do nothing
     		}
     	}
@@ Expand Down @@