Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lemminx Maven erroneously process non-pom.xml files #27

Closed
mickaelistria opened this issue Apr 23, 2020 · 0 comments · Fixed by #29
Closed

Lemminx Maven erroneously process non-pom.xml files #27

mickaelistria opened this issue Apr 23, 2020 · 0 comments · Fixed by #29
Labels
bug Something isn't working

Comments

@mickaelistria
Copy link
Contributor

Severity: **** (blocker for first release)

Open any XML file with lemminx-maven available, and there will be pom error reported on the file.
It looks like all the "participants" have to add

if (!MavenPlugin.match(...)) {
  return;
}
@AObuchow AObuchow added the bug Something isn't working label Apr 23, 2020
AObuchow added a commit to AObuchow/lemminx-maven that referenced this issue Apr 23, 2020
AObuchow added a commit to AObuchow/lemminx-maven that referenced this issue Apr 23, 2020
AObuchow added a commit to AObuchow/lemminx-maven that referenced this issue Apr 24, 2020
Fix eclipse-lemminx#27
Stop testRemoteArtifactHover from failing even if it was successful

Signed-off-by: Andrew Obuchowicz <[email protected]>
AObuchow added a commit that referenced this issue Apr 24, 2020
Fix #27
Stop testRemoteArtifactHover from failing even if it was successful

Signed-off-by: Andrew Obuchowicz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants