Fix #253: JKubeServiceHub BuildService implementations are now loaded via PluginServiceFactory #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on mechanism + Use ServiceLoader to load all Build Services and pick up service which is applicable in current context. This requires BuildService implementations to have zero-arg constructors so I need to set the elements from setters instead. + Added isApplicable(), setJKubeServiceHub(), methods in BuildService interface Signed-off-by: Rohan Kumar <[email protected]>
12 tasks
manusa
force-pushed
the
review/build-service-SPI
branch
from
7ed2489 to
140e7b3
Compare
manusa
force-pushed
the
review/build-service-SPI
branch
2 times, most recently
from
5eff5a8 to
8db3631
Compare
- Refactor OpenshiftBuildService - Improve coverage - Add specific tests for build service election order or the different Quarkus packaging modes Signed-off-by: Marc Nuri <[email protected]>
manusa
force-pushed
the
review/build-service-SPI
branch
from
8db3631 to
4854f43
Compare
Codecov Report
@@ Coverage Diff @@
## master #772 +/- ##
============================================
+ Coverage 46.21% 46.36% +0.15%
- Complexity 3246 3261 +15
============================================
Files 413 415 +2
Lines 19856 19852 -4
Branches 2781 2778 -3
============================================
+ Hits 9176 9204 +28
+ Misses 9661 9633 -28
+ Partials 1019 1015 -4
Continue to review full report at Codecov.
|
...src/main/java/org/eclipse/jkube/kit/config/service/openshift/OpenShiftBuildServiceUtils.java
Outdated
Show resolved
Hide resolved
rohanKanojia
approved these changes
Jul 14, 2021
Reuse the PluginServiceFactory that provides injection for Generators and Enrichers. Order of BuildService can be declared using our internal syntax in the service definition files. or the different Quarkus packaging modes Signed-off-by: Marc Nuri <[email protected]>
manusa
force-pushed
the
review/build-service-SPI
branch
from
4854f43 to
e1cf1ab
Compare
|
Kudos, SonarCloud Quality Gate passed! |
rohanKanojia
reviewed
Aug 4, 2021
| clusterAccess = new ClusterAccess(log, | ||
| ClusterConfiguration.from(System.getProperties(), jKubeServiceHub.getConfiguration().getProject().getProperties()).build()); | ||
| } | ||
| client = clusterAccess.createDefaultClient(); |
There was a problem hiding this comment.
assigning value of clusterAccess.createDefaultClient() which can either be DefaultKubernetesClient or DefaultOpenShiftClient seems to OpenShiftClient client seems to be causing #815
In v1.3.0, this code was in JKubeServiceHub and client was of type KubernetesClient
https://github.com/eclipse/jkube/blob/v1.3.0/jkube-kit/config/service/src/main/java/org/eclipse/jkube/kit/config/service/JKubeServiceHub.java#L62
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supersedes closes #748
Fixes #253
Complete refactor of the BuildService(s) and load process in JKubeServiceHub
Type of change
test, version modification, documentation, etc.)
Checklist