Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning in PodLogService when no running pod is found #284

Merged
merged 1 commit into from
Jul 17, 2020

Conversation

rohanKanojia
Copy link
Member

We no longer have start and stop goals. Replacing those with deploy
and undeploy

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #284 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #284   +/-   ##
=========================================
  Coverage     33.04%   33.04%           
  Complexity     2099     2099           
=========================================
  Files           362      362           
  Lines         18512    18512           
  Branches       2744     2744           
=========================================
  Hits           6117     6117           
  Misses        11664    11664           
  Partials        731      731           
Impacted Files Coverage Δ Complexity Δ
...clipse/jkube/kit/config/service/PodLogService.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8555e05...f619a29. Read the comment docs.

@rohanKanojia rohanKanojia requested a review from manusa July 9, 2020 10:37
@manusa
Copy link
Member

manusa commented Jul 16, 2020

We are assuming that this code will be executed by a Maven invocation (which will not always be true, especially when we add other types of plugins).

We need to find a way to provide meaningful warnings (just like what you did), but that are still compatible with any runtime (Maven, Gradle, JKube-kit standalone...).

So maybe something in the lines of:
No pod is running yet. Are you sure you deployed your app using Eclipse JKube apply/deploy mechanism?
Or did you undeploy it? If so try running the Eclipse JKube apply/deploy tasks again.

We no longer have start and stop goals. Replacing those with deploy
and undeploy
@rohanKanojia rohanKanojia force-pushed the pr/fix-logmojo-message branch from db527fd to f619a29 Compare July 17, 2020 11:29
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_131) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@manusa manusa merged commit a23661c into eclipse-jkube:master Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants