Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Debug goals work on webapp (Tomcat & Jetty) #269

Merged
merged 1 commit into from
Jul 1, 2020

Conversation

manusa
Copy link
Member

@manusa manusa commented Jun 30, 2020

Description

fix #245: Debug goals work on webapp (Tomcat & Jetty)

Related commits:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

@codecov
Copy link

codecov bot commented Jun 30, 2020

Codecov Report

Merging #269 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #269   +/-   ##
=========================================
  Coverage     30.89%   30.89%           
  Complexity     1942     1942           
=========================================
  Files           359      359           
  Lines         18300    18300           
  Branches       2741     2741           
=========================================
  Hits           5654     5654           
  Misses        11988    11988           
  Partials        658      658           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 565739c...370fd9a. Read the comment docs.

@manusa manusa force-pushed the fix/webapp-debug branch from b99ec47 to 370fd9a Compare June 30, 2020 13:03
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (1.8.0_131) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

Copy link
Member

@rohanKanojia rohanKanojia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@manusa manusa merged commit d8b7637 into eclipse-jkube:master Jul 1, 2020
@manusa manusa deleted the fix/webapp-debug branch July 1, 2020 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debug goal for Web Applications
2 participants