-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc (jkube-kit/doc) : Documentation for Buildpacks integration #2639
Conversation
Eclipse JKube CI ReportStarted new GH workflow run for #2639 (2024-02-09T05:02:46Z) ⚙️ JKube E2E Tests (7839778679)
|
9e0d038
to
ae9ac45
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2639 +/- ##
=============================================
+ Coverage 59.36% 70.44% +11.08%
- Complexity 4586 4994 +408
=============================================
Files 500 486 -14
Lines 21211 19454 -1757
Branches 2830 2504 -326
=============================================
+ Hits 12591 13704 +1113
+ Misses 7370 4525 -2845
+ Partials 1250 1225 -25 ☔ View full report in Codecov by Sentry. |
df6e4ce
to
d73fdef
Compare
5b6f49e
to
f5a996c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check my comments and I'll perform a new review once you've updated the branch.
Your last intermediate changes made me lose track of the current review
It would also be good to rebase this so the helm changes are also reflected. |
e3a247d
to
9c5d486
Compare
+ Move `_integrations.adoc` from `kubernetes-maven-plugin` to `jkube-kit/doc` + Move `_jkube-build.adoc` from `kubernetes-maven-plugin` + `gradle-plugin` to `jkube-kit/doc` + Add section related to Buildpacks in integrations Signed-off-by: Rohan Kumar <[email protected]>
9c5d486
to
e4aaae3
Compare
Quality Gate passedIssues Measures |
Description
Fix #2465
_integrations.adoc
fromkubernetes-maven-plugin
tojkube-kit/doc
misc/_startup.adoc
fromkubernetes-maven-plugin
/gradle-plugin
tojkube-kit/doc
misc/_env.adoc
fromkubernetes-maven-plugin
/gradle-plugins
tojkube-kit/doc
_jkube-build.adoc
fromkubernetes-maven-plugin
andgradle-plugin
tojkube-kit/doc
. Both maven and gradle plugins would generate documentation for build action from_jkube-build.adoc
injkube-kit/doc
Global Groovy DSL Configuration
defined in gradle-plugin/doc tojkube-kit/doc/inc/build/_build_configuration_option_entries.adoc
Kubernetes Build
/OpenShift Build
headings from build goal/task docs, now that we have separate plugins for kubernetes and openshift, it doesn't make sense for these headings.Type of change
test, version modification, documentation, etc.)
Checklist