Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DockerFileBuilder only supports *nix paths (Dockerfile Linux only) #262

Merged
merged 1 commit into from
Jun 26, 2020

Conversation

manusa
Copy link
Member

@manusa manusa commented Jun 26, 2020

Description

DockerFileBuilder only supports *nix paths (Dockerfile Linux only)

  • Fixed provided invalid default configs (Dockerfile mode, etc.)

Fixes: #261

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

- fixed invalid default configs

Signed-off-by: Marc Nuri <[email protected]>
@codecov
Copy link

codecov bot commented Jun 26, 2020

Codecov Report

Merging #262 into master will increase coverage by 1.93%.
The diff coverage is 62.68%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #262      +/-   ##
============================================
+ Coverage     28.73%   30.67%   +1.93%     
- Complexity     1731     1923     +192     
============================================
  Files           355      358       +3     
  Lines         18235    18317      +82     
  Branches       2764     2751      -13     
============================================
+ Hits           5240     5618     +378     
+ Misses        12377    12040     -337     
- Partials        618      659      +41     
Impacted Files Coverage Δ Complexity Δ
...e/jkube/kit/build/service/docker/BuildService.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...e/jkube/kit/build/service/docker/WatchService.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../kit/build/service/docker/config/ConfigHelper.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...vice/docker/config/handler/property/ConfigKey.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...config/handler/property/PropertyConfigHandler.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...eclipse/jkube/kit/config/access/ClusterAccess.java 66.66% <ø> (-20.00%) 7.00 <0.00> (-6.00)
...eclipse/jkube/kit/config/resource/RuntimeMode.java 0.00% <0.00%> (-83.34%) 0.00 <0.00> (-3.00)
...kube/springboot/generator/SpringBootGenerator.java 17.85% <ø> (ø) 8.00 <0.00> (ø)
...be/maven/plugin/mojo/build/AbstractDockerMojo.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ube/maven/plugin/mojo/build/AbstractJKubeMojo.java 12.12% <0.00%> (-7.88%) 2.00 <0.00> (ø)
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b573deb...9df57a5. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_131) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@rohanKanojia rohanKanojia merged commit 045556e into eclipse-jkube:master Jun 26, 2020
@manusa manusa deleted the fix/windows-build branch June 26, 2020 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build errors on windows 10
2 participants