Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace Quarkus Native Base image with ubi-minimal (same as… #252

Merged

Conversation

manusa
Copy link
Member

@manusa manusa commented Jun 19, 2020

Description

Replace Quarkus Native Base image with ubi-minimal (same as in Dockerfile.native)

registry.fedoraproject.org is down many times and registry.fedoraproject.org/fedora-minimal:latest is not even the same base image Quarkus uses in its Dockerfile.native. This changes the base image to the one used in the mentioned file.

TODO: Need to refactor QuarkusGenerator to behave like the other generators, and pick up base image configurations (not hardcoded).

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

@manusa manusa force-pushed the fix/quarkus-native-base-image branch from 432b5d7 to 644b809 Compare June 19, 2020 11:11
@manusa manusa force-pushed the fix/quarkus-native-base-image branch from 644b809 to fd96a01 Compare June 19, 2020 11:19
@codecov
Copy link

codecov bot commented Jun 19, 2020

Codecov Report

Merging #252 into master will increase coverage by 0.31%.
The diff coverage is 59.15%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #252      +/-   ##
============================================
+ Coverage     28.91%   29.22%   +0.31%     
- Complexity     1749     1793      +44     
============================================
  Files           355      355              
  Lines         18215    18198      -17     
  Branches       2751     2750       -1     
============================================
+ Hits           5266     5318      +52     
+ Misses        12330    12259      -71     
- Partials        619      621       +2     
Impacted Files Coverage Δ Complexity Δ
...e/jkube/kit/build/service/docker/BuildService.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...e/jkube/kit/build/service/docker/WatchService.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../kit/build/service/docker/config/ConfigHelper.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...vice/docker/config/handler/property/ConfigKey.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...config/handler/property/PropertyConfigHandler.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...kube/springboot/generator/SpringBootGenerator.java 17.85% <ø> (ø) 8.00 <0.00> (ø)
...be/maven/plugin/mojo/build/AbstractDockerMojo.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...se/jkube/maven/plugin/mojo/build/ResourceMojo.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...onfig/service/openshift/OpenshiftBuildService.java 53.01% <33.33%> (ø) 46.00 <0.00> (ø)
...ube/kit/config/image/build/BuildConfiguration.java 59.45% <59.81%> (+37.85%) 57.00 <55.00> (+37.00)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d290c13...fd96a01. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_131) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@rohanKanojia rohanKanojia merged commit eaa0380 into eclipse-jkube:master Jun 19, 2020
@manusa manusa deleted the fix/quarkus-native-base-image branch June 19, 2020 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants